feat(token-lists): Tests for checksummed address #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChefKai
requested review from
Chef-Chungus,
hachiojidev and
RabbitDoge
as code owners
ChefKai
commented
Aug 20, 2021
| @@ -145,7 +143,14 @@ describe.each([["pancakeswap-default"], ["pancakeswap-extended"], ["pancakeswap- | |||
|
|
|||
| it("all addresses are valid and checksummed", () => { | |||
| for (const token of defaultTokenList.tokens) { | |||
| expect(getAddress(token.address)).toBe(token.address); | |||
| expect(token.address).toBe(getAddress(token.address)); | |||
There was a problem hiding this comment.
Wrong side; it's expect actual to be formatted actual
ChefKai
commented
Aug 20, 2021
| const refersToLocalLogo = | ||
| token.logoURI === `https://tokens.pancakeswap.finance/images/${token.address}.png` || | ||
| token.logoURI === `https://tokens.pancakeswap.finance/images/${token.address.toLowerCase()}.png`; | ||
| const refersToLocalLogo = token.logoURI === `https://tokens.pancakeswap.finance/images/${token.address}.png`; |
There was a problem hiding this comment.
Ensure all URI's are checksummed
ChefKai
commented
Aug 20, 2021
| } | ||
| }); | ||
|
|
||
| it("all logos addresses are valid and checksummed", async () => { |
There was a problem hiding this comment.
Ensure that token logo as image are checksummed
Chef-Cheems
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.