Feature/connect wallet modal v2 #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hachiojidev
commented
Jul 15, 2021
hachiojidev
commented
Jul 15, 2021
hachiojidev
force-pushed
the
feature/connect-wallet-modal-v2
branch
2 times, most recently
from
9e87a18 to
0dc1037
Compare
hachiojidev
force-pushed
the
feature/connect-wallet-modal-v2
branch
from
b054442 to
0ff5251
Compare
RabbitDoge
reviewed
Jul 28, 2021
RabbitDoge
reviewed
Jul 28, 2021
| * | ||
| * @returns sorted config | ||
| */ | ||
| const getPreferredConfig = (walletConfig: Config[]) => { |
There was a problem hiding this comment.
this logic should be in the app now, inside the user reducer (like all the config related to the user). The reducer is already serialized so we don't have to manipulate the local storage directly
RabbitDoge
reviewed
Jul 28, 2021
packages/pancake-uikit/src/widgets/WalletModal/ConnectModal.tsx
Outdated
Show resolved
Hide resolved
RabbitDoge
approved these changes
Jul 28, 2021
|
Formating issue |
* feat(uikit): Fallback to Wallet Connect for iOS users * fix: WalletConnect on iOS
* feat(uikit): Save last connected wallet * test: Update snapshot * style: Update text styles
hachiojidev
force-pushed
the
feature/connect-wallet-modal-v2
branch
from
0ff5251 to
4b493dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redesign wallet modal. Note - further functionality will be in a separate PR.