Enable Formatting and linting #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 8, 2023 14:06
* Adding the github actions to lint and fmt on each PR * Initial linting changes * Initial formatting changes
* Addresses gosec linting: G112: Potential Slowloris Attack because ReadHeaderTimeout is not configured in the http.Server
* Addresses gosec linting: G303: File creation in shared tmp directory without using ioutil.Tempfile
taariq
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Before starting on the next feature, it's pretty clear this repo needs some linting. There is a lot of inconsistency and even some unused code. This should now be taken care of
Testing completed