Version 1.0.0 removed previously deprecated code

[evanlurvey]

The 1.0.0 release that was pushed 2 hours ago published breaking changes for people using flask. Not sure if it was a desired effect and flask should pin their version or if changes in this project need to happen.

[ThiefMaster]

Please post full tracebacks if you encounter any issues.

[davidism]

The issue is not with Flask, and Werkzeug will not continue supporting these deprecated imports. 0.16 has been issuing deprecation warnings for 5 months. Use that version as an intermediate step to identify what imports have changed.

You can help extensions and other projects by opening an issue or submitting a PR in the relevant project.

• Flask-Admin 1.5.5
• Flask-Babel 1.0
• Flask-BabelEx 0.9.4
• flask-restplus (not merged, unmaintained in favor of flask-restx)
• flask-restx (merged, not released yet)
• Flask-Testing 0.8.0
• Flask-WTF 0.14.3
• django-extensions 2.2.8
• pytest-flask 0.15.1

[seancanham]

+1, having the following issue:

    from werkzeug import url_encode
ImportError: cannot import name 'url_encode'```

[mitsuhiko]

This is a completely awful user experience. Flask-WTF 0.14.3 with the fixes was released hours ago. How are we pushing out a release that removes support when massive parts of the ecosystem were not ready for this?

This is I believe the third time an update to one of the pallets libraries broke code I had running in less than six months.

[Abdelsalam-Abbas]

similar issue

Traceback (most recent call last):
  File "/usr/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/ubuntu/swagger-codegen/samples/server/petstore/flaskConnexion/swagger_server/__main__.py", line 3, in <module>
    import connexion
  File "/home/ubuntu/.local/lib/python3.6/site-packages/connexion/__init__.py", line 3, in <module>
    from .apis import AbstractAPI  # NOQA
  File "/home/ubuntu/.local/lib/python3.6/site-packages/connexion/apis/__init__.py", line 1, in <module>
    from .abstract import AbstractAPI  # NOQA
  File "/home/ubuntu/.local/lib/python3.6/site-packages/connexion/apis/abstract.py", line 14, in <module>
    from ..operation import Operation
  File "/home/ubuntu/.local/lib/python3.6/site-packages/connexion/operation.py", line 7, in <module>
    from .decorators import validation
  File "/home/ubuntu/.local/lib/python3.6/site-packages/connexion/decorators/validation.py", line 9, in <module>
    from werkzeug import FileStorage
ImportError: cannot import name 'FileStorage'

workaround
add werkzeug == 0.16.1 to requirements.txt solved it for me

[jugmac00]

@Abdelsalam-Abbas connexion fixed that import back in October 2019 - maybe you are running an old version?
https://github.com/zalando/connexion/releases/tag/2.4.0

[LucasLLC]

Would someone mind providing some insight into why my flask request object returned from werkzeug's LocalProxy is from a different version then what I have locally?

Since this release I'm getting this error:

    if current_app.config['JSONIFY_PRETTYPRINT_REGULAR'] and not request.is_xhr:
  File "/Users/lucas/Software/anaconda3/envs/pytest/lib/python3.6/site-packages/werkzeug/local.py", line 347, in __getattr__
    return getattr(self._get_current_object(), name)
AttributeError: 'Request' object has no attribute 'is_xhr'

is_xhr is a property that was removed in Flask 1.0, but locally I have 0.12.2 installed. Just to be clear, I'm posting this issue here because the bug is not in Flask, rather I'm just confused as to why/how LocalProxy is returning a newer version of this Flask app then I'm expecting.

[pgjones]

@LucasLLC is_xhr was never directly part of Flask (is there a reference that states it was removed in Flask 1.0? I can't see it in the changelog) rather it has always been a Werkzeug API that Flask exposes. In terms of Werkzeug you can see it is removed in 81e10ef.

If you aren't already I'd recommend pinning your dependencies and periodically upgrading, a chore that is made easy by tools such as poetry.

[mitsuhiko]

@pgjones ideally we do a bugfix release of flask 0.12 which pins werkzeug to < 1.0.0. This is afterall a bad pin in Flask.

[mitsuhiko]

Also yes, this API is effectively Flask API and it was documented as such: https://flask.palletsprojects.com/en/0.12.x/api/#flask.Request.is_xhr

[LucasLLC]

@LucasLLC is_xhr was never directly part of Flask (is there a reference that states it was removed in Flask 1.0? I can't see it in the changelog) rather it has always been a Werkzeug API that Flask exposes. In terms of Werkzeug you can see it is removed in 81e10ef.

Ah, my mistake. I was referencing the warning generated in this method, and didn't realize it was coming from Werkzeug, that makes a lot more sense.

If you aren't already I'd recommend pinning your dependencies and periodically upgrading, a chore that is made easy by tools such as poetry.

Thanks for the tip! We'll look into poetry.