Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pip-compile-multi #161

Merged
merged 1 commit into from
May 18, 2020
Merged

remove pip-compile-multi #161

merged 1 commit into from
May 18, 2020

Conversation

davidism
Copy link
Member

@davidism davidism commented May 18, 2020

Dependabot isn't compatible with it, it always uses pip-compile directly, which produces different output (different header without update hash, all requirements inline). I want to use pip-compile-multi since it's convenient and has a pre-commit hook. If Dependabot fixes compatibility (dependabot/dependabot-core#536) I can add it back in.

See discussion in #159. CC @peterdemin

dependabot isn't compatible with it
@davidism davidism merged commit 39ce571 into master May 18, 2020
@davidism davidism deleted the pip-compile branch May 18, 2020 16:41
@peterdemin
Copy link

Hi @davidism, I did some experiments with GitHub Actions and I found an alternative to dependabot, that suites my needs:
https://github.com/peterdemin/pip-compile-multi/blob/master/.github/workflows/pipcompilemulti.yml
It runs pip-compile-multi weekly and creates a PR if there were changes to lock files.
Let me know what you think 🙏
Comparing to dependabot:
Pros:

  • More control of the locking process. Allows creating both .txt and .hash files, for example.
  • Allows locking platform-specific dependencies, like atomicwrites, which is pytest dependency under win32.
    Cons:
  • Not aware of existing PRs, so if repo is left unattended, PRs tend to pile-up.
  • Needs long GitHub Actions config file.

I want to beta-test it with you and then advertise to the public in README.

@davidism
Copy link
Member Author

Can you open an issue on pip-compile-multi for discussion and ping me? I'm interested in this but we should discuss it in a dedicated place.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants