Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow #5665

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Workflow #5665

wants to merge 2 commits into from

Conversation

pgjones
Copy link
Member

@pgjones pgjones commented Jan 2, 2025

No description provided.

This will allow it to be used in Quart, thereby reducing duplication,
and ensuring the APIs match.
This should allow for a large reduction in duplicated action code
across the pallet's repos.
@pgjones pgjones force-pushed the workflow branch 3 times, most recently from 145f61f to 4044716 Compare January 2, 2025 21:17
@davidism
Copy link
Member

davidism commented Jan 2, 2025

It doesn't seem to cut down on much boilerplate, there's still approximately the same amount of workflow code to keep synced across projects. Is there more than can be done?

@pgjones
Copy link
Member Author

pgjones commented Jan 3, 2025

Yea, I can also change the pre-commit and publish workflows to use shared actions. If we like this pattern?

@pgjones
Copy link
Member Author

pgjones commented Jan 5, 2025

Added pre-commit and build actions - will clean up and fix if we like this pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants