Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing reset in isolation function #2733

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

Tyl13
Copy link
Contributor

@Tyl13 Tyl13 commented May 22, 2024

Adds missing _compat.should_strip_ansi reset back to the original version of the function.

fixes #2732

  • Add tests that demonstrate the correct behavior of the change. Tests
    should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.

@davidism davidism modified the milestone: 8.1.8 May 22, 2024
@AndreasBackx AndreasBackx force-pushed the fix-missing-reset branch 3 times, most recently from 63877be to 3f770df Compare November 9, 2024 22:01
@davidism davidism merged commit fdc6b02 into pallets:stable Dec 4, 2024
12 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants