Explicit explanation of the breaking change in 7.0 #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidism could you give it a quick check? It's just a change to docs, not code. Just to highlight the issue with v7.0. Thanks!! |
|
Thanks for writing this. I rewrote it to mention the different options for upgrading from #1123 (comment) and rebased it to the 7.x branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the discussion in #1123 and seeing how this has bitten people (even if it can be expected because it's a major version and people should pin versions, etc) I think it would be nice to be explicit about such a change and list it in the "Upgrade" section.