Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German translations for 'confirmation instructions' #917

Merged

Conversation

sr-verde
Copy link
Contributor

@sr-verde sr-verde commented Feb 6, 2024

In this PR, I am trying to get some better, more user-friendly wording for the German translations of 'confirmation instructions'. Even more, I differ from the English original and try to give the user helpful instructions. So, the current English version is:

Thank you. Confirmation instructions have been sent to user@example.com.

I have translated that to something like:

Thank you. To confirm your email address %(email)s, please click on the link in the email we have just sent to you.

One may want to adapt that for other languages as well.

I also translated "confirmation instructions" to "confirmation link" ("Bestätigungslink"). But "confirmation instructions" doesn't sound as weird (to me as a non-native speaker) as it does in German.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0b971c1) 98.40% compared to head (4e5d898) 98.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #917   +/-   ##
=======================================
  Coverage   98.40%   98.40%           
=======================================
  Files          35       35           
  Lines        4508     4508           
=======================================
  Hits         4436     4436           
  Misses         72       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwag956 jwag956 merged commit 3b84c92 into pallets-eco:master Feb 6, 2024
19 checks passed
@jwag956
Copy link
Collaborator

jwag956 commented Feb 6, 2024

I'll look into changing the default/English... (and try to keep your translation!).

Thanks.

jwag956 added a commit that referenced this pull request Feb 22, 2024
Changed CONFIRM_REGISTRATION as suggested by #917
@jwag956 jwag956 mentioned this pull request Feb 22, 2024
jwag956 added a commit that referenced this pull request Feb 23, 2024
Changed CONFIRM_REGISTRATION as suggested by #917
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants