Improve CSRF #908
Merged
Improve CSRF #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #908 +/- ##
=======================================
Coverage 98.38% 98.39%
=======================================
Files 34 34
Lines 4465 4484 +19
=======================================
+ Hits 4393 4412 +19
Misses 72 72 ☔ View full report in Codecov by Sentry. |
Added testing to /tf-setup - there wasn't any CSRF issue - all working. CSRF handling is complex and there are few unit tests. - Added @pytest.mark.csrf to make it easier to turn on and test CSRF w/o lots of boilerplate - Added tests and improved many templates to show CSRF errors - mostly for developers - but otherwise CSRF errors tent do just disappear and are difficult to debug - Found issue with WTFforms with the new form-level errors - it uses a `None` key - which, if there are multiple errors, isn't sortable by Flasks default JSON serializer. Filed issue and now change if from `None` to "" - Fixed issue in webauthn with CSRF errors causing exceptions - added tests. - In the case of CSRFprotect() (the app configuring CSRF for the entire app) a CSRF error would raise an exception which would always return an HTML response - added code to return a JSON response if desired. closes #905
Added testing to /tf-setup - there wasn't any CSRF issue - all working. CSRF handling is complex and there are few unit tests. - Added @pytest.mark.csrf to make it easier to turn on and test CSRF w/o lots of boilerplate - Added tests and improved many templates to show CSRF errors - mostly for developers - but otherwise CSRF errors tent do just disappear and are difficult to debug - Found issue with WTFforms with the new form-level errors - it uses a `None` key - which, if there are multiple errors, isn't sortable by Flasks default JSON serializer. Filed issue and now change if from `None` to "" - Fixed issue in webauthn with CSRF errors causing exceptions - added tests. - In the case of CSRFprotect() (the app configuring CSRF for the entire app) a CSRF error would raise an exception which would always return an HTML response - added code to return a JSON response if desired. - Add more documentation... closes #905
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added testing to /tf-setup - there wasn't any CSRF issue - all working.
CSRF handling is complex and there are few unit tests.
Nonekey - which, if there are multiple errors, isn't sortable by Flasks default JSON serializer. Filed issue and now change if fromNoneto ""closes #905