simplify weakref handling #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the built-in `WeakMethod` and `inspect.ismethod` instead of a custom implementation. Build a cleanup callback from an id, rather than storing the id on an `annnotatable_weakref` subclass. Simplify the private `Symbol` class implementation. Use the built-in `cached_property` instead of a custom implementation. Use positional-only argument for `send(sender)` instead of `*args` hack. This simplified the type annotations, which pass with pyright as well now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the built-in
WeakMethodandinspect.ismethodinstead of a custom implementation.Build a cleanup callback from an id, rather than storing the id on an
annnotatable_weakrefsubclass.Simplify the private
Symbolclass implementation.Use the built-in
cached_propertyinstead of a custom implementation.Use positional-only argument for
send(sender)instead of*argshack.This simplified the type annotations, which pass with pyright as well now.