Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added latest risk score, risk category and evaluation date to Active On ART linelist #1875

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

patryllus
Copy link

Screenshot from 2024-04-30 15-56-26
Screenshot from 2024-04-30 15-56-59

@patryllus patryllus marked this pull request as draft April 30, 2024 13:17
@patryllus
Copy link
Author

Testing with QA (Rajab) team to determine if there is any effect on Current on ART report generation time taken with the addition of risk score related fields

EvaluatedPersonData c = new EvaluatedPersonData(definition, context);

String qry = "select ml.patient_id,\n" +
" mid(max(concat(ml.date_created ,concat(ml.description ))),20) as risk_score\n" +

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an idea of a visit in the ML risk score table? I am a bit worried about scores which are retrospectively generated.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen an evaluation date column. I think that is more ideal than the date created column

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ojwanganto : mid(max(concat(ml.date_created ,NULLIF(concat(date(ml.evaluation_date)),'0000-00-00'))),20)
Rationale:
I pick the max evaluation_date where date_created <= date(:endDate)

This is because we lack visit_date in this table

@patryllus patryllus marked this pull request as ready for review June 3, 2024 09:03
@andrineM
Copy link

andrineM commented Jun 3, 2024

@ojwanganto @patryllus can this changes please be merged for us to test?

Copy link

@PatrickWaweru PatrickWaweru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@PatrickWaweru PatrickWaweru merged commit 9a852ce into palladiumkenya:master Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants