-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modified the two tables to move them to their new schemas #528
base: dev
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis PR updates the schema references in two SQL scripts, moving tables from the 'dbo' schema to the 'Care' schema. The changes maintain the same table structure and logic while only updating the schema names in the queries. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @DennisGibz - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider maintaining consistent casing for table names (e.g., choose either 'all_EMRSites' or 'ALL_EMRSites' and use it consistently throughout the code)
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DennisGibz LGTM. The all move to separate schemas makes things easier & organized. Great work!
Summary by Sourcery
Enhancements: