Filtering out invalid VLs from suppression computation #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marymary-dev
requested review from
nobert-mumo,
cbrianbet,
DennisGibz and
klanyo
nobert-mumo
requested changes
Oct 4, 2024
| @@ -60,7 +60,7 @@ Select distinct | |||
| end as ARTOutcomeDescription, | |||
| vl.EligibleVL as Eligible4VL, | |||
| vl.HasValidVL, | |||
| vl.ValidVLSup, | |||
| Case when vl.HasValidVL= 1 Then vl.ValidVLSup Else 0 End as ValidVLSup, | |||
There was a problem hiding this comment.
@Marymary-dev oh interesting, should we do the fix at the fact level? I think if the name of the column is ValidVLSup then the issue could be on the fact logic
There was a problem hiding this comment.
@nobert-mumo this has been fixed at the Fact level
nobert-mumo
reviewed
Oct 7, 2024
| @@ -296,7 +296,7 @@ RepeatVlUnSupp as (Select | |||
| case when pbfw_clients.PatientPK is not null then 1 else 0 end as IsPBFW, | |||
| valid_VL_indicators.ValidVLResultCategory1, | |||
| valid_VL_indicators.ValidVLResultCategory2, | |||
| case when valid_VL_indicators.ValidVLSup is not null then valid_VL_indicators.ValidVLSup else 0 end as ValidVLSup, | |||
| case when valid_VL_indicators.PatientPK is not null and valid_VL_indicators.ValidVLSup is not null then valid_VL_indicators.ValidVLSup else 0 end as ValidVLSup, | |||
There was a problem hiding this comment.
@Marymary-dev maybe we need to go inside the validVLSup CTE and understand what changed? I see ValidVLSup comes from the CTE on valid_VL_indicators which contains all valid vls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.