Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding changes to ARTOutcomes model #461

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

Marymary-dev
Copy link
Contributor

No description provided.

@DennisGibz
Copy link
Contributor

@Marymary-dev Is it LIHMIS or LHMIS? Depending on your abbreviation, harmonize on the script accordingly.

  	   union all
	select 'LIHMIS' as ARTOutcome

and

WHEN [ARTOutcome] = 'LHMIS' THEN 'LOST IN HMIS'

@Marymary-dev
Copy link
Contributor Author

@Marymary-dev Is it LIHMIS or LHMIS? Depending on your abbreviation, harmonize on the script accordingly.

  	   union all
	select 'LIHMIS' as ARTOutcome

and

WHEN [ARTOutcome] = 'LHMIS' THEN 'LOST IN HMIS'

@DennisGibz the I has been added in the DimARTOutcome

DennisGibz
DennisGibz previously approved these changes Jul 17, 2024
@DennisGibz
Copy link
Contributor

@Marymary-dev , Just and been curious. You had added the same on the Intermediate outcomes table then later closed the PR. How will above amendment on the Dim marry what we will have on the Intermediate outcomes?

@Marymary-dev
Copy link
Contributor Author

@Marymary-dev , Just and been curious. You had added the same on the Intermediate outcomes table then later closed the PR. How will above amendment on the Dim marry what we will have on the Intermediate outcomes?

@DennisGibz this PR has 2 files that were changed

@DennisGibz DennisGibz self-requested a review July 17, 2024 13:02
@DennisGibz DennisGibz dismissed their stale review July 17, 2024 13:05

Allow me to check the intermediate outcome script

@Marymary-dev Marymary-dev merged commit 84b9e24 into dev Jul 17, 2024
@DennisGibz
Copy link
Contributor

@Marymary-dev by " DATEADD(day, 1 - DAY(GETDATE()), GETDATE()) " what happens if an upload is done at 30th or 31st of the reporting month? According to the script the site will be classified as LOST IN HMIS?

Copy link
Contributor Author

All uploads should be done between 1st and 15th , this is the guidance for reporting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants