Added FactHistoricalViralLoad script. Yet to add PBFW logi #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@DennisGibz the logic is incorrect here, you are saying if datediff ordered date and asof <12 and they are adults then they have invalid vls which is wrong, we can link up kesho to discuss this
| END As EligibleVL, | ||
| CASE | ||
| WHEN datediff(month,[OrderedbyDate],@as_of_date) <= 6 and Datediff(year,Patient.DOB,@as_of_date) <= 24 THEN 1 | ||
| WHEN datediff(month,[OrderedbyDate],@as_of_date) <= 12 and Datediff(year,Patient.DOB,@as_of_date) > 24 THEN 1 |
There was a problem hiding this comment.
@DennisGibz the logic is incorrect here, you are saying if datediff ordered date and asof <12 and they are adults then they have invalid vls which is wrong, we can link up kesho to discuss this
nobert-mumo
requested changes
Jan 6, 2025
|
|
||
|
|
||
|
|
||
| TRUNCATE TABLE ndwh.dbo.FactViralLoad_Hist; |
There was a problem hiding this comment.
@DennisGibz just curious, why have two truncate statements for the same table in the script?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.