-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hiv cs tx continuity #451
base: dev
Are you sure you want to change the base?
Hiv cs tx continuity #451
Conversation
…HIV_CS_TxContinuity
,Patient.Gender | ||
,Patient.DOB | ||
,[AgeGroup].DATIMAgeGroup | ||
,FactARTHistory.AgeGroup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DennisGibz not sure, I thought since this is a Fact we should be using an AgeGroupKey?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DennisGibz not sure, I thought since this is a Fact we should be using an AgeGroupKey?
@nobert-mumo yes but DimAgegroup was bringing about discrepancy in numbers. We have changed the report to be a linelist. |
@DennisGibz not sure I follow, do you mean we changed the fact to a report ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure the CohortYearMonth is set to EndofMonth for ease of filtering
@@ -23,7 +23,7 @@ BEGIN | |||
,YEAR(TRY_CAST(DateConfirmedHIVPositiveKey AS DATETIME2)) As CohortYear | |||
,TRY_CAST(DateConfirmedHIVPositiveKey AS DATETIME2) As CohortYearMonth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure the CohortYearMonth is set to EndofMonth for ease of filtering
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Marymary-dev this has since been addressed.
@nobert-mumo this was never a fact. We have factARTHistory as the source fact. |
@DennisGibz I thought [NDWH].[dbo].[FactARTHistory] is a fact ? then we should be having an |
Yeah. We can have the dim attached to the fact then consume the column downstream. I'll look at that. |
@DennisGibz , the table |
No description provided.