Revert "Let's not add a constraint on the size, on CALLDATACOPY"

This reverts commit 499c84d.
palkeo · Mar 24, 2019 · b630f47 · b630f47
1 parent c01d1cd
commit b630f47
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/pakala/sm.py b/pakala/sm.py
@@ -477,8 +477,7 @@ def solution(variable):
                     self.add_for_fuzzing(old_state, size, CALLDATACOPY_SIZE_FUZZ)
                     return False
                 state.memory.copy_from(state.env.calldata, mstart, dstart, size)
-                # We don't add a constraint on the size here. We can copy something
-                # out of bound, it's fine. See consensys diligence ROP EVM challenge.
+                state.solver.add(state.env.calldata_size >= dstart + size)
             elif op == opcode_values.CODESIZE:
                 state.stack_push(bvv(len(self.code)))
             elif op == opcode_values.EXTCODESIZE: