File locking #43
Merged
File locking #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @llamicron and @gilescope. You opened a pair of issues (#30 and #41 respectively) that both needed file-based locking. This branch ( |
|
Excellent! This weekend I rewrote the cargo parallel test PR so it's time to try and pull it all together. Should be able to get a green build while most of the tests run in parallel. |
|
In the absence of other feedback, I'm merging this now as I think it solves both the core use cases. If there's bugs in it, please file as issues as per normal. Thanks! |
This was referenced Nov 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds file-based locking behind the
file_locksfeature