Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

align: fix false positive with BOM #2642

Merged
merged 1 commit into from
Apr 29, 2017
Merged

align: fix false positive with BOM #2642

merged 1 commit into from
Apr 29, 2017

Conversation

ajafff
Copy link
Contributor

@ajafff ajafff commented Apr 26, 2017

PR checklist

Overview of change:

[bugfix] align: fix false positive for files with BOM
Fixes: #2640
/cc @unicron

Is there anything you'd like reviewers to focus on?

CHANGELOG.md entry:

[bugfix] `align`: fix false positive for files with BOM
Fixes: #2640
@unicron
Copy link

unicron commented Apr 26, 2017

Hi and thanks. Sorry, am I meant to review the PR since I was cc'd or is there a group of reviewers that does that?

@ajafff
Copy link
Contributor Author

ajafff commented Apr 27, 2017

@unicron You're not supposed to review the code. I just tagged you here, so you can track the progress of the fix.

If you want, you can test if my fix really fixes your problem. Simply run the following commands:

# go to a directory where you want to temporarily clone the tslint repo to
git clone https://github.com/palantir/tslint.git
cd tslint
git fetch origin pull/2642/head:2642
git checkout 2642
npm install # or yarn install
npm run compile:test

# now go to your project you want to lint
node <path/to/tslint>/build/src/tslint-cli <options># replace this with the options you want pass to tslint

There may of course be other lint errors coming from rules that changed since the last release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrectly receive statements are not aligned error with align rule
3 participants