This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Add number-literal-format rule
#2526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajafff
suggested changes
Apr 8, 2017
src/rules/numberLiteralFormatRule.ts
Outdated
| } | ||
|
|
||
| // Allow '10', but not '1.0' | ||
| if (text.endsWith("0") && text.includes(".")) { |
There was a problem hiding this comment.
you will get false positives for 1.1e10 and will not catch 1.0e1
consider node.getText(sourceFile).replace(/[eE]-?\d+$/, "")
Edit: should also work for 1.0e-1
src/rules/numberLiteralFormatRule.ts
Outdated
| return; | ||
| } | ||
|
|
||
| if (text.startsWith(".")) { |
There was a problem hiding this comment.
consider adding a check for .endsWith('.') for literals like 1. (or 1.e1 - see my other comment)
ajafff
reviewed
Apr 9, 2017
src/rules/numberLiteralFormatRule.ts
Outdated
| function check(node: ts.NumericLiteral): void { | ||
| // Apparently the number literal '0.0' has a '.text' of '0', so use '.getText()' instead. | ||
| const text = node.getText(sourceFile); | ||
| if (text.includes("e")) { |
There was a problem hiding this comment.
e can also be uppercase
also consider removing this if statement in favor of some thing like this:
const [num, exp] = text.split(/e/i);
if (exp !== undefined) {
// check exponent for leading zero
}
// check num, you don't need an extra function and a callback for adding the failure
ajafff
reviewed
Apr 9, 2017
src/rules/numberLiteralFormatRule.ts
Outdated
| } | ||
|
|
||
| function checkFormat(text: string, fail: (message: string) => void): void { | ||
| if (text.length <= 1) { |
There was a problem hiding this comment.
add || !text.includes(".") and remove it from the other condition below
ajafff
approved these changes
Apr 10, 2017
andy-hanson
force-pushed
the
number-literal-format
branch
from
c9d358e to
3ec5417
Compare
adidahiya
approved these changes
Apr 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Added the
number-literal-formatrule, which warns on.5and0.50(both: prefer0.5).This could also be extended to implement #1391 if anyone wants that.
CHANGELOG.md entry:
[new-rule]
number-literal-format