Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Add fixer for eofline rule #2393

Merged
merged 1 commit into from
Mar 25, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/rules/eoflineRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ export class Rule extends Lint.Rules.AbstractRule {
optionsDescription: "Not configurable.",
options: null,
optionExamples: ["true"],
hasFix: true,
type: "maintainability",
typescriptOnly: false,
};
Expand All @@ -41,9 +42,16 @@ export class Rule extends Lint.Rules.AbstractRule {
return [];
}

let fix: Lint.Fix | undefined;
const lines = sourceFile.getLineStarts();
if (lines.length > 1) {
fix = new Lint.Fix(this.ruleName, [
Lint.Replacement.appendText(length, sourceFile.text[lines[1] - 2] === "\r" ? "\r\n" : "\n"),
]);
}

return this.filterFailures([
new Lint.RuleFailure(sourceFile, length, length, Rule.FAILURE_STRING,
this.getOptions().ruleName),
new Lint.RuleFailure(sourceFile, length, length, Rule.FAILURE_STRING, this.ruleName, fix),
]);
}
}
8 changes: 0 additions & 8 deletions test/rules/eofline/disabled/tslint.json

This file was deleted.

8 changes: 0 additions & 8 deletions test/rules/eofline/empty/tslint.json

This file was deleted.

1 change: 1 addition & 0 deletions test/rules/eofline/invalid.js.fix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
let foo = bar;
1 change: 1 addition & 0 deletions test/rules/eofline/invalid.ts.fix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
let foo = bar;
8 changes: 0 additions & 8 deletions test/rules/eofline/invalid/tslint.json

This file was deleted.

2 changes: 2 additions & 0 deletions test/rules/eofline/only-whitespace.js.fix
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@


2 changes: 2 additions & 0 deletions test/rules/eofline/only-whitespace.ts.fix
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@


8 changes: 0 additions & 8 deletions test/rules/eofline/only-whitespace/tslint.json

This file was deleted.

8 changes: 0 additions & 8 deletions test/rules/eofline/valid/tslint.json

This file was deleted.

8 changes: 0 additions & 8 deletions test/rules/eofline/whitespace/tslint.json

This file was deleted.