Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Bugfix for radix rule and property access #2352

Merged
merged 1 commit into from
Apr 2, 2017
Merged

Bugfix for radix rule and property access #2352

merged 1 commit into from
Apr 2, 2017

Conversation

ajafff
Copy link
Contributor

@ajafff ajafff commented Mar 15, 2017

PR checklist

Overview of change:

[bugfix] don't warn for missing radix on method calls
[enhancement] added check for global.parseInt and window.parseInt

[bugfix] don't warn for missing radix on method calls
Fixes: #2281
[enhancement] added check for global.parseInt and window.parseInt
@andy-hanson
Copy link
Contributor

I wouldn't mark this as fixing #2281 since fixing that would require making this an OptionallyTypedRule.

@ajafff
Copy link
Contributor Author

ajafff commented Mar 16, 2017

You are right, that it does not fix all cases.
I wouldn't make it an OptionallyTypedRule, because it would not fail in CLI but fail in vscode, which is really annoying.

Also other rules like this (no-eval, no-construct, array-type, ...) don't check if the identifier is shadowed. That's what line switches are made for.

If the current behavior is really a problem (awating more feedback on this), we could use some code from no-shadowed-variable (I'm currently working on a reusable utility)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants