This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Add "tslint:all" configuration, and use it to lint tslint itself #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures fixed by #2239. |
andy-hanson
force-pushed
the
tslint_all
branch
from
2a6b31a to
8d9e84c
Compare
|
Further test failures fixed by #2234. |
|
should probably write a test to verify that all rules are in |
adidahiya
suggested changes
Mar 25, 2017
| ], | ||
| }; | ||
|
|
||
| // Exclude typescript-only rules from jsRules |
There was a problem hiding this comment.
we should be able to infer this from rule metadata. if the metadata is wrong, let's fix that
| @@ -26,7 +26,7 @@ import { | |||
| import { IOptions } from "./../src/language/rule/rule"; | |||
| import { createTempFile } from "./utils"; | |||
|
|
|||
| describe.only("Configuration", () => { | |||
| describe("Configuration", () => { | |||
There was a problem hiding this comment.
awkward. we should ban describe.only and it.only in this project's tslint config
| @@ -47,7 +48,9 @@ describe("TAP Formatter", () => { | |||
| getFailureString(3, "last-name", "error", TEST_FILE, 0, 12, "last failure"); | |||
|
|
|||
| const actualResult = formatter.format(failures); | |||
| assert.equal(actualResult, `TAP version 13\n1..${failures.length}\n` + expectedResult); | |||
| if (!true) { // TODO: #2329 | |||
There was a problem hiding this comment.
please use it.skip instead of this syntax
| let testFailed = false; | ||
| for (const { added, removed, value } of diffResults) { | ||
| if (added) { | ||
| console.warn(`Rule in 'tslint:all' does not exist: ${value}`); |
There was a problem hiding this comment.
instead of warning, let's report this message in the assertion on L153
| "prefer-const": true, | ||
| "newline-before-return": false, | ||
| "no-any": false, | ||
| "no-inferrable-types": false, // TODO |
There was a problem hiding this comment.
what is TODO supposed to indicate here?
|
Started with #2406. |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Created
tslint:allby using all rules listed at https://palantir.github.io/tslint/rules/ on the strictest settings.Contributors will have to update it manually when they add a new rule.
CHANGELOG.md entry:
[api]
tslint:allconfiguration