Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Include type definitions for failure fix JSON? #1788

Closed
JoshuaKGoldberg opened this issue Nov 24, 2016 · 0 comments · Fixed by singapore/lint-condo#223
Closed

Include type definitions for failure fix JSON? #1788

JoshuaKGoldberg opened this issue Nov 24, 2016 · 0 comments · Fixed by singapore/lint-condo#223

Comments

@JoshuaKGoldberg
Copy link
Contributor

In src/language/rule/rule.ts they're all listed as any.

public toJson(): any {
    return {
        endPosition: this.endPosition.toJson(),
        failure: this.failure,
        fix: this.fix,
        name: this.fileName,
        ruleName: this.ruleName,
        startPosition: this.startPosition.toJson(),
    };
}

Would it be reasonable to include type definitions instead?

Proposal: https://github.com/autolint/autotslint/blob/3d151cf33af44527c77256099933fe6b6f0d3fcf/src/ruleFailureJson.ts

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant