Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

object-literal-sort-keys singleline/multiline #1642

Closed
ezhukovskiy opened this issue Oct 19, 2016 · 2 comments · Fixed by #1646
Closed

object-literal-sort-keys singleline/multiline #1642

ezhukovskiy opened this issue Oct 19, 2016 · 2 comments · Fixed by #1646

Comments

@ezhukovskiy
Copy link
Contributor

Hi,
I believe that it will be very useful to add multiline/singleline options to object-literal-sort-keys rule as you have in trailing-comma, because having one line objects sorted alphabetically has no sense for simplifying of merging.
Thanks!

@adidahiya
Copy link
Contributor

@EugeneZee you're right, I actually think the rule should ignore single line literals by default. We probably don't even need an option to enforce sorting there, but can add one back if users request it. Will happily take this change for v4.0.

@ezhukovskiy
Copy link
Contributor Author

@adidahiya thanks! I completely agree that it should be disabled for single lines by default.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants