Add noEmit to compilerOptions (#2823)

palantir · May 24, 2017 · 8b0ef1e · 8b0ef1e
1 parent d39070d
commit 8b0ef1e
Show file tree

Hide file tree

Showing 7 changed files with 32 additions and 4 deletions.
diff --git a/src/linter.ts b/src/linter.ts
@@ -64,7 +64,7 @@ class Linter {
             readFile: (file) => fs.readFileSync(file, "utf8"),
             useCaseSensitiveFileNames: true,
         };
-        const parsed = ts.parseJsonConfigFileContent(config, parseConfigHost, path.resolve(projectDirectory));
+        const parsed = ts.parseJsonConfigFileContent(config, parseConfigHost, path.resolve(projectDirectory), {noEmit: true});
         const host = ts.createCompilerHost(parsed.options, true);
         const program = ts.createProgram(parsed.fileNames, parsed.options, host);
 

diff --git a/src/rules/noUnusedVariableRule.ts b/src/rules/noUnusedVariableRule.ts
@@ -367,7 +367,12 @@ function getUnusedCheckedProgram(program: ts.Program, checkParameters: boolean):
 }
 
 function makeUnusedCheckedProgram(program: ts.Program, checkParameters: boolean): ts.Program {
-    const options = { ...program.getCompilerOptions(), noUnusedLocals: true, ...(checkParameters ? { noUnusedParameters: true } : null) };
+    const options = {
+        ...program.getCompilerOptions(),
+        noEmit: true,
+        noUnusedLocals: true,
+        ...(checkParameters ? { noUnusedParameters: true } : null),
+    };
     const sourceFilesByName = new Map<string, ts.SourceFile>(
         program.getSourceFiles().map<[string, ts.SourceFile]>((s) => [getCanonicalFileName(s.fileName), s]));
 

diff --git a/test/executable/executableTests.ts b/test/executable/executableTests.ts
@@ -328,6 +328,16 @@ describe("Executable", function(this: Mocha.ISuiteCallbackContext) {
                     done();
                 });
         });
+
+        it("can handles 'allowJs' correctly", (done) => {
+            execCli(
+                [ "-p", "test/files/tsconfig-allow-js/tsconfig.json"],
+                (err) => {
+                    assert.isNotNull(err, "process should exit with error");
+                    assert.strictEqual(err.code, 2, "error code should be 2");
+                    done();
+                });
+        });
     });
 
     describe("--type-check", () => {

diff --git a/test/files/tsconfig-allow-js/testfile.test.js b/test/files/tsconfig-allow-js/testfile.test.js
@@ -0,0 +1 @@
+module.exports = {}
diff --git a/test/files/tsconfig-allow-js/tsconfig.json b/test/files/tsconfig-allow-js/tsconfig.json
@@ -0,0 +1,6 @@
+{
+    "compilerOptions": {
+        "allowJs": true,
+        "noEmit": false
+    }
+}
diff --git a/test/files/tsconfig-allow-js/tslint.json b/test/files/tsconfig-allow-js/tslint.json
@@ -0,0 +1,8 @@
+{
+    "jsRules": {
+        "eofline": true,
+        "semicolon": [
+            true, "always"
+        ]
+    }
+}
diff --git a/test/rules/strict-boolean-expressions/allow-boolean-undefined-union/test.ts.lint b/test/rules/strict-boolean-expressions/allow-boolean-undefined-union/test.ts.lint
@@ -7,9 +7,7 @@ if (get<true | false | undefined>()) {}
 if (get<true | false | undefined | void>()) {}
 
 if (get<true>()) {}
-    ~~~~~~~~~~~ [err % ("'if' condition", 'is always truthy')]
 if (get<true | true>()) {}
-    ~~~~~~~~~~~~~~~~~~ [err % ("'if' condition", 'is always truthy')]
 if (get<false | undefined>()) {}
     ~~~~~~~~~~~~~~~~~~~~~~~~ [err % ("'if' condition", 'is always falsy')]
 if (get<undefined>()) {}