Edit tslint.json (#2344)

palantir · Mar 14, 2017 · 2dad217 · 2dad217
1 parent 4f1d667
commit 2dad217
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 4 deletions.
diff --git a/src/rules/noInferrableTypesRule.ts b/src/rules/noInferrableTypesRule.ts
@@ -92,7 +92,6 @@ class NoInferrableTypesWalker extends Lint.AbstractWalker<IOptions> {
                     /* falls through*/
                 case ts.SyntaxKind.VariableDeclaration:
                     this.checkDeclaration(node as ts.VariableLikeDeclaration);
-                default:
             }
             return ts.forEachChild(node, cb);
         };

diff --git a/src/rules/noUnnecessaryQualifierRule.ts b/src/rules/noUnnecessaryQualifierRule.ts
@@ -72,7 +72,7 @@ class Walker extends Lint.ProgramAwareRuleWalker {
                     this.visitNamespaceAccess(node, expression, name);
                     break;
                 }
-                // fall through
+                // falls through
             default:
                 super.visitNode(node);
         }

diff --git a/src/rules/strictTypePredicatesRule.ts b/src/rules/strictTypePredicatesRule.ts
@@ -135,7 +135,7 @@ function getTypePredicateOneWay(left: ts.Expression, right: ts.Expression, isStr
             if ((right as ts.Identifier).originalKeywordKind === ts.SyntaxKind.UndefinedKeyword) {
                 return nullOrUndefined(undefinedFlags);
             }
-
+            return undefined;
         default:
             return undefined;
     }

diff --git a/test/rules/_integration/enable-disable/tslint.json b/test/rules/_integration/enable-disable/tslint.json
@@ -6,6 +6,8 @@
     "comment-format": [
       true,
       "check-space"
-    ]
+    ],
+    "no-switch-case-fall-through": true,
+    "switch-default": false
   }
 }
diff --git a/tslint.json b/tslint.json
@@ -21,7 +21,9 @@
     "no-default-export": true,
     "no-empty-interface": true,
     "no-string-throw": true,
+    "no-switch-case-fall-through": true,
     "prefer-const": true,
+    "switch-default": false,
     "variable-name": [true,
       "ban-keywords",
       "check-format",