Fix false positive in typedef rule for catch clause (#1887)

palantir · Dec 16, 2016 · 0b15029 · 0b15029
1 parent 2218cfc
commit 0b15029
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/rules/typedefRule.ts b/src/rules/typedefRule.ts
@@ -185,7 +185,7 @@ class TypedefWalker extends Lint.RuleWalker {
         // catch statements will be the parent of the variable declaration
         // for-in/for-of loops will be the gradparent of the variable declaration
         if (node.parent != null && node.parent.parent != null
-                && node.parent.parent.kind !== ts.SyntaxKind.CatchClause
+                && (node as ts.Node).parent.kind !== ts.SyntaxKind.CatchClause
                 && node.parent.parent.kind !== ts.SyntaxKind.ForInStatement
                 && node.parent.parent.kind !== ts.SyntaxKind.ForOfStatement) {
             this.checkTypeAnnotation("variable-declaration", node.name.getEnd(), node.type, node.name);

diff --git a/test/rules/typedef/all/test.ts.lint b/test/rules/typedef/all/test.ts.lint
@@ -1,3 +1,8 @@
+// should not error with missing exception type
+try {
+} catch (e) {
+}
+
 var NoTypeObjectLiteralWithPropertyGetter = {
                                          ~    [expected variable-declaration: 'NoTypeObjectLiteralWithPropertyGetter' to have a typedef]
     Prop: "some property",