Upgrade gradle-baseline and error-prone #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
reviewed
Dec 10, 2019
| @@ -90,7 +90,7 @@ private static void checkPublicStaticMethod(Method method) { | |||
| private static RuntimeException throwUnchecked(ReflectiveOperationException reflectionException) { | |||
| Throwable cause = reflectionException.getCause() != null ? reflectionException.getCause() : reflectionException; | |||
| Throwables.throwIfUnchecked(cause); | |||
| throw new RuntimeException(cause); | |||
carterkozak
approved these changes
Dec 10, 2019
This was referenced Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Outdated gradle-baseline and error-prone were being used. Error-prone 2.3.4 was released on 2019-12-02 with
Performance Improvements: 40% speedup when run against Google's codebase with errors enabled.and a bunch of new checks.After this PR
==COMMIT_MSG==
Upgrade gradle-baseline to 2.41.0 and error-prone compiler to 2.3.4
==COMMIT_MSG==
Possible downsides?
Works around a couple error-prone bugs by suppressing
TryFailRefactoringonRemotingCompatibleTracingInvocationEventHandler.Supersedes and closes #535, #536, #537