Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gradle-baseline and error-prone #538

Merged
merged 9 commits into from
Dec 10, 2019
Merged

Conversation

schlosna
Copy link
Contributor

@schlosna schlosna commented Dec 10, 2019

Before this PR

Outdated gradle-baseline and error-prone were being used. Error-prone 2.3.4 was released on 2019-12-02 with Performance Improvements: 40% speedup when run against Google's codebase with errors enabled. and a bunch of new checks.

After this PR

==COMMIT_MSG==
Upgrade gradle-baseline to 2.41.0 and error-prone compiler to 2.3.4
==COMMIT_MSG==

Possible downsides?

Works around a couple error-prone bugs by suppressing TryFailRefactoring on RemotingCompatibleTracingInvocationEventHandler.

Supersedes and closes #535, #536, #537

@changelog-app
Copy link

changelog-app bot commented Dec 10, 2019

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Upgrade gradle-baseline to 2.41.0 and error-prone compiler to 2.3.4

Check the box to generate changelog(s)

  • Generate changelog entry

@@ -90,7 +90,7 @@ private static void checkPublicStaticMethod(Method method) {
private static RuntimeException throwUnchecked(ReflectiveOperationException reflectionException) {
Throwable cause = reflectionException.getCause() != null ? reflectionException.getCause() : reflectionException;
Throwables.throwIfUnchecked(cause);
throw new RuntimeException(cause);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants