Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify JavaDoc for InstrumentationFilters enum #537

Closed
wants to merge 3 commits into from
Closed

Specify JavaDoc for InstrumentationFilters enum #537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b1b785
Upgrade to gradle-baseline 2.41.0
schlosna Dec 9, 2019
cb31af3
More specific runtime exception
schlosna Dec 9, 2019
da6d706
Add JavaDoc to InstrumentationFilters
schlosna Dec 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ buildscript {
classpath 'com.jfrog.bintray.gradle:gradle-bintray-plugin:1.8.4'
classpath 'com.netflix.nebula:gradle-info-plugin:5.2.0'
classpath 'com.netflix.nebula:nebula-publishing-plugin:14.1.1'
classpath 'com.palantir.baseline:gradle-baseline-java:2.37.0'
classpath 'com.palantir.baseline:gradle-baseline-java:2.41.0'
classpath 'com.palantir.gradle.consistentversions:gradle-consistent-versions:1.13.1'
classpath 'com.palantir.gradle.gitversion:gradle-git-version:0.12.2'
classpath 'com.palantir.metricschema:gradle-metric-schema:0.4.8'
Expand Down
6 changes: 6 additions & 0 deletions tritium-core/src/main/java/com/palantir/tritium/event/InstrumentationFilters.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@

public enum InstrumentationFilters implements InstrumentationFilter {

/**
* Instrument all invocations.
*/
INSTRUMENT_ALL {
@Override
public boolean shouldInstrument(
Expand All @@ -32,6 +35,9 @@ public boolean shouldInstrument(
}
},

/**
* Instrument no invocations.
*/
INSTRUMENT_NONE {
@Override
public boolean shouldInstrument(
Expand Down
2 changes: 1 addition & 1 deletion tritium-tracing/src/main/java/com/palantir/tritium/tracing/ReflectiveTracer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ private static List<String> paramsToClassNames(Method method) {
private static RuntimeException throwUnchecked(ReflectiveOperationException reflectionException) {
Throwable cause = reflectionException.getCause() != null ? reflectionException.getCause() : reflectionException;
Throwables.throwIfUnchecked(cause);
throw new RuntimeException(cause);
throw new IllegalStateException(cause);
}

}