Skip to content
This repository has been archived by the owner on Jan 18, 2021. It is now read-only.

Updated to use go modules #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updated to use go modules #10

wants to merge 2 commits into from

Conversation

tapirs
Copy link

@tapirs tapirs commented Apr 12, 2019

removed the vendor directory and initiated as a module
updated tfjson_test
Updated circle ci config
Added env variable to turn on modules
added env variable to test run and added names to runs
updated env variable
installed terraform
downloading dependencies before building terraform

@nmiyake
Copy link
Collaborator

nmiyake commented Apr 12, 2019

Thanks for the PR!

I've updated the project to use CircleCI 2.0, so it should be possible to update/touch up your PR and have the jobs run. Once this is running in CI I can provide feedback on the actual PR.

removed the vendor directory and initiated as a module
updated tfjson_test
Updated circle ci config
Added env variable to turn on modules
added env variable to test run and added names to runs
updated env variable
installed terraform
downloading dependencies before building terraform
@tapirs
Copy link
Author

tapirs commented Apr 15, 2019

Hi I have updated my PR to pass all of the tests, the only problem is go version 1.10 doesn't support modules and so the vendor directory has to be included so implementing modules then becomes pointless as the dependencies are satisfied within the repo.

Would it be better to create a release containing the vendor director for pre 1.11 go and then test only using version 1.11 and version 1.12 after that?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants