Skip to content

Commit

Permalink
[SPARK-26744][SPARK-26744][SQL][HOTFOX] Disable schema validation tes…
Browse files Browse the repository at this point in the history
…ts for FileDataSourceV2 (partially revert )

## What changes were proposed in this pull request?

This PR partially revert SPARK-26744.

apache@60caa92 and apache@4dce45a were merged at similar time range independently. So the test failures were not caught.

- apache@60caa92 happened to add a schema reading logic in writing path for overwrite mode as well.

- apache@4dce45a added some tests with overwrite modes with migrated ORC v2.

And the tests looks starting to fail.

I guess the discussion won't be short (see apache#23606 (comment)) and this PR proposes to disable the tests added at apache@4dce45a to unblock other PRs for now.

## How was this patch tested?

Existing tests.

Closes apache#23828 from HyukjinKwon/SPARK-26744.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
  • Loading branch information
HyukjinKwon authored and mccheah committed May 15, 2019
1 parent 4661671 commit ee834f7
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ class FileBasedDataSourceSuite extends QueryTest with SharedSQLContext with Befo
test("SPARK-24204 error handling for unsupported Interval data types - csv, json, parquet, orc") {
withTempDir { dir =>
val tempDir = new File(dir, "files").getCanonicalPath
Seq(true, false).foreach { useV1 =>
Seq(true).foreach { useV1 =>
val useV1List = if (useV1) {
"orc"
} else {
Expand Down Expand Up @@ -379,7 +379,7 @@ class FileBasedDataSourceSuite extends QueryTest with SharedSQLContext with Befo
}

test("SPARK-24204 error handling for unsupported Null data types - csv, parquet, orc") {
Seq(true, false).foreach { useV1 =>
Seq(true).foreach { useV1 =>
val useV1List = if (useV1) {
"orc"
} else {
Expand Down

0 comments on commit ee834f7

Please sign in to comment.