Do not set scheme if unset #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
iambenjackson
approved these changes
Mar 1, 2023
ellisjoe
reviewed
Mar 3, 2023
| @@ -164,6 +164,9 @@ private static Function<Path, Path> setSchemeFunc(final String scheme) { | |||
|
|
|||
| private static Function<URI, URI> setUriSchemeFunc(final String scheme) { | |||
| return uri -> { | |||
| if (uri.getScheme() == null) { | |||
There was a problem hiding this comment.
Two quick things:
- Do you have an example where things have broken when this scheme is set?
- Can we write a test that illustrates this behavior in action?
alexmaass
approved these changes
Mar 3, 2023
ellisjoe
approved these changes
Mar 3, 2023
|
Released 3.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
StandaloneEncryptedFileSystem#setUriSchemeFunc will always set the uri's scheme, even if it's not already set.
After this PR
We only set the scheme if it's already set. This matches the behavior of this class in 2.9.2: https://github.com/palantir/hadoop-crypto/pull/442/files#diff-050a60db63beecf42d4d99e5e9132ee7f6dc68ae9b552e37ff5ccd2a109806d6L166
==COMMIT_MSG==
StandaloneEncryptedFileSystem returns to its old behavior, of only overriding the scheme when the uri uses a scheme
==COMMIT_MSG==
Possible downsides?