This repository has been archived by the owner on Sep 19, 2024. It is now read-only.
revapiAcceptAllBreaks now works when there are multiple breaks #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
CRogers
approved these changes
Oct 2, 2019
|
Released 1.0.2 |
iamdanfox
commented
Oct 2, 2019
| @@ -57,6 +57,7 @@ dependencies { | |||
| testImplementation "org.junit.jupiter:junit-jupiter" | |||
| testImplementation 'org.mockito:mockito-core' | |||
| testImplementation 'org.assertj:assertj-core' | |||
| testRuntimeOnly "org.junit.vintage:junit-vintage-engine" | |||
There was a problem hiding this comment.
deleting this line makes spock tests silently not run. 🔥🔥🔥
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
my last PR (released as 1.0.1) allowed accepting a single break, but didn't work when there are multiple.
Also tests weren't running on CircleCI 🌶🌶🌶🌶
After this PR
==COMMIT_MSG==
revapiAcceptAllBreaks now works when there are multiple breaks
==COMMIT_MSG==
Possible downsides?