Excavator: Upgrades Baseline to the latest version

[svc-excavator-bot]

excavator is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

Release Notes

2.4.0

Type	Description	Link
Improvement	A new StrictUnusedVariable check will catch any unused arguments (e.g. AuthHeaders) to public methods. If you need to suppress this, rename your variable to have an underscore prefix (e.g. s/foo/_foo/) or just run ./gradlew classes -PerrorProneApply to auto-fix	palantir/gradle-baseline#819
Improvement	Message format checks use instanceof rather than catching	palantir/gradle-baseline#821

2.4.1

Type	Description	Link
Fix	Avoid false positives caused by module-info.class when checking class uniqueness	palantir/gradle-baseline#823

2.4.2

Type	Description	Link
Fix	Checkstyle tasks only check their own source set and only actual java sources. They don't look in your src/*/resources directory anymore.	palantir/gradle-baseline#830

2.4.3

Type	Description	Link
Fix	Add link to StrictUnusedVariable that directs users to baseline repo.	palantir/gradle-baseline#829
Fix	Long try-with-resources statements are now aligned such that the first assignment stays on the first line.	palantir/gradle-baseline#835

2.5.0

Type	Description	Link
Improvement	Error Prone StringBuilderConstantParameters. StringBuilder with a constant number of parameters should be replaced by simple concatenation. The Java compiler (jdk8) replaces concatenation of a constant number of arguments with a StringBuilder, while jdk 9+ take advantage of JEP 280 (https://openjdk.java.net/jeps/280) to efficiently pre-size the result for better performance than a StringBuilder.	palantir/gradle-baseline#832

2.6.0

Type	Description	Link
Fix	Excavator PRs that apply other refaster rules (e.g. Witchcraft ones) will not also apply baseline refaster rules.	palantir/gradle-baseline#827
Improvement	Added a new ErrorProne check PreferAssertj to assist migration to AssertJ from legacy test frameworks. It may be necessary to add a dependency on org.assertj:assertj-core in modules which do not already depend on AssertJ. If there's a technical reason that AssertJ cannot be used, PreferAssertj may be explicitly disabled to prevent future upgrades from attempting to re-run the migration.	palantir/gradle-baseline#841

2.7.0

Type	Description	Link
Improvement	StrictUnusedVariable now ignores variables prefixed with _ and the suggested fix will rename all unused parameters in public methods instead of removing them	palantir/gradle-baseline#833
Improvement	ErrorProne will now detect dangerous usage of @RunWith(Suite.class) that references JUnit5 classes, as this can cause tests to silently not run!	palantir/gradle-baseline#843

2.8.0

Type	Description	Link
Fix	PreferAssertj provides better replacements fixes	palantir/gradle-baseline#850
Improvement	Do not run error prone on any code in the build directory	palantir/gradle-baseline#853

2.8.1

Type	Description	Link
Fix	Fix hamcrest arrayContainingInAnyOrder conversion	palantir/gradle-baseline#859

2.9.0

Type	Description	Link
Improvement	StrictUnusedVariable can only be suppressed with _ prefix	palantir/gradle-baseline#854
Improvement	StrictUnusedVariable is now an error by default	palantir/gradle-baseline#855
Fix	The PreferAssertj refactoring will only be applied if you have explicitly opted in (e.g. using baselineErrorProne { patchChecks += 'PreferAssertj' }	palantir/gradle-baseline#861

2.9.1

Type	Description	Link
Fix	Error prone will correctly ignore all source files in the build directory and in any generated source directory	palantir/gradle-baseline#864
Fix	Ensure that StrictUnusedVariable correctly converts previously suppressed variables unused to _	palantir/gradle-baseline#865

2.9.2

Type	Description	Link
Fix	When removing unused variables, StrictUnusedVariable will preserve side effects	palantir/gradle-baseline#870

2.10.0

Type	Description	Link
Improvement	A new checkJUnitDependencies task detects misconfigured JUnit dependencies which could result in some tests silently not running.	palantir/gradle-baseline#837
Improvement	Some AssertJ assertions can now be automatically replaced with more idiomatic ones using refaster.	palantir/gradle-baseline#851
Fix	PreferAssertj check avoids ambiguity in assertThat invocations	palantir/gradle-baseline#874
Improvement	Improve performannce of error prone PreferAssertj check	palantir/gradle-baseline#875
Improvement	StringBuilderConstantParameters suggested fix doesn't remove comments	palantir/gradle-baseline#877

2.10.1

Type	Description	Link
Fix	Allow junit4 dependencies to exist without junit4 tests	palantir/gradle-baseline#880

2.11.0

Type	Description	Link
Improvement	PreferAssertj supports migration of zero-delta floating point array asserts	palantir/gradle-baseline#883

2.11.1

Type	Description	Link
Fix	checkJunitDependencies only checks Java source	palantir/gradle-baseline#885

2.11.2

Type	Description	Link
Fix	AssertJ Refaster fixes use static assertThat imports	palantir/gradle-baseline#887

2.12.0

Type	Description	Link
Improvement	Disable UnusedVariable error prone rule by default	palantir/gradle-baseline#888

2.13.0

Type	Description	Link
Improvement	Refaster for AssertJ isZero/isNotZero/isOne and collections	palantir/gradle-baseline#881
Improvement	AssertJ refaster migrations support string descriptions	palantir/gradle-baseline#891
Fix	Certain error-prone checks are disabled in test code, and the presence of JUnit5's @TestTemplate annotation is now used to detect whether a class is test code.	palantir/gradle-baseline#892
Fix	BaselineFormat task exclude generated code on Windows	palantir/gradle-baseline#896

2.14.0

Type	Description	Link
Improvement	Refaster rules for AssertJ tests	palantir/gradle-baseline#898
Improvement	refaster replacement for assertj hasSize(foo.size) -> hasSameSizeAs	palantir/gradle-baseline#900
Fix	Keep spotless plugin from eagerly configuring all tasks	diffplug/spotless#444
Fix	Continue when RefasterRuleBuilderScanner throws	palantir/gradle-baseline#904
Improvement	Refaster now works on repos using Gradle 6.0	palantir/gradle-baseline#804, palantir/gradle-baseline#906

2.15.0

No documented user facing changes

2.16.0

Type	Description	Link
Improvement	Rewrite ImmutableCollection#addAll to add for arrays	palantir/gradle-baseline#743
Improvement	Add refaster rule to simplify empty optional asserts	palantir/gradle-baseline#911
Improvement	Baseline now allows static imports of AssertJ and Mockito methods.	palantir/gradle-baseline#915
Improvement	Remove refaster AssertjIsOne rule.	palantir/gradle-baseline#917
Improvement	Add assertj refaster rules for map size asserts	palantir/gradle-baseline#919
Improvement	Added a Refaster rule to change isEqualTo checks into hasValue checks

2.17.0

Type	Description	Link
Improvement	Implement AssertjCollectionHasSameSizeAsArray	palantir/gradle-baseline#922
Improvement	Implement assertj map refactors for containsKey and containsEntry	palantir/gradle-baseline#925
Improvement	Refaster assertj migrations support descriptions with format args	palantir/gradle-baseline#926
Improvement	Refaster out String.format from describedAs	palantir/gradle-baseline#927

2.18.0

Type	Description	Link
Improvement	Refaster rules to simplify negated boolean expressions and extract null checks.	palantir/gradle-baseline#935
Improvement	Refaster rules for checks that maps do not contain a specific key	palantir/gradle-baseline#935
Improvement	Refaster rule 'CollectionStreamForEach'	palantir/gradle-baseline#942
Improvement	ExecutorSubmitRunnableFutureIgnored as error prone ERROR	palantir/gradle-baseline#943

2.19.0

Type	Description	Link
Improvement	checkJUnitDependencies detects a possible misconfiguration with spock and JUnit5 which could lead to tests silently not running.	palantir/gradle-baseline#951

To enable or disable this check, please contact the maintainers of Excavator.