Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: Load palantir-java-format dynamically #989

Merged
merged 12 commits into from
Oct 22, 2019
Merged

Improvement: Load palantir-java-format dynamically #989

merged 12 commits into from
Oct 22, 2019

Commits on Oct 18, 2019

  1. WIP PalantirJavaFormatStep, but not sure if we can use the API direct… 

    …ly...
    @dansanduleac
    dansanduleac committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    30167b0 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2019

  1. format BaselineFormat

    @dansanduleac
    dansanduleac committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    e9be62d View commit details
    Browse the repository at this point in the history

  2. This works

    @dansanduleac
    dansanduleac committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    7f9d8f0 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/develop' into ds/dynamically-loa… 

    …d-pjf

# Conflicts:
#	versions.props
    @dansanduleac
    dansanduleac committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    e1c33bf View commit details
    Browse the repository at this point in the history

  4. Try to service load via spotless classloader, fail

    @dansanduleac
    dansanduleac committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    188ab74 View commit details
    Browse the repository at this point in the history

  5. get rid of dead fields

    @dansanduleac
    dansanduleac committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    36b428a View commit details
    Browse the repository at this point in the history

  6. Use classloader from extension, but pass in configuration for caching… 

    … purposes
    @dansanduleac
    dansanduleac committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    18b1a18 View commit details
    Browse the repository at this point in the history

  7. regenerate test

    @dansanduleac
    dansanduleac committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    7607d30 View commit details
    Browse the repository at this point in the history

  8. fix check

    @dansanduleac
    dansanduleac committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    4f80d9a View commit details
    Browse the repository at this point in the history

  9. ensure implementation is not loadable, otherwise classloading is broken.

    @dansanduleac
    dansanduleac committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    719e269 View commit details
    Browse the repository at this point in the history

  10. Add generated changelog entries

    @dansanduleac
    dansanduleac committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    b043fa6 View commit details
    Browse the repository at this point in the history

  11. I can spell, yes...

    @dansanduleac
    dansanduleac committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    74355fa View commit details
    Browse the repository at this point in the history