correct out of date Java style guide #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gracew
commented
May 1, 2018
| @@ -221,12 +221,6 @@ top-level class it contains, plus the `.java` extension. | |||
|
|
|||
| Source files are encoded in **UTF-8**. | |||
|
|
|||
| ### File length: 2000 lines | |||
| @@ -332,10 +326,8 @@ Unused or redundant imports should be removed. | |||
|
|
|||
| Static imports of project-specific methods limit readability as they | |||
| obfuscate method provenance. Static imports are thus discouraged with | |||
| the exception of folklore methods under `org.junit.Assert`, | |||
There was a problem hiding this comment.
nit: worth matching
gradle-baseline/.baseline/checkstyle/checkstyle.xml
Lines 82 to 83 in 219602b
There was a problem hiding this comment.
didn't want to have to update the docs every time we change that checkstyle rule -- but I guess we shouldn't be changing it so much after #240?
qinfchen
approved these changes
May 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.