Bring IntelliJ in sync with ErrorProne on bad inner static class names #2447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
schlosna
approved these changes
Nov 5, 2022
schlosna
reviewed
Nov 5, 2022
| <DO_NOT_IMPORT_INNER> | ||
| <CLASS name="Builder" /> | ||
| <CLASS name="BuilderFactory" /> |
There was a problem hiding this comment.
Looks like this has been out of sync for a while
| @@ -54,6 +56,7 @@ | |||
| <CLASS name="Type" /> | |||
| <CLASS name="Key" /> | |||
| <CLASS name="Id" /> | |||
| <CLASS name="Identifier" /> | |||
There was a problem hiding this comment.
This was recently added to error-prone
This was referenced Dec 7, 2022
This was referenced Dec 9, 2022
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Dec 9, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.184.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Bring IntelliJ in sync with ErrorProne on bad inner static class names | palantir/gradle-baseline#2447 | | Fix | Suppress the `JavaxInjectOnAbstractMethod` check for projects that apply `java-gradle-plugin`. | palantir/gradle-baseline#2460 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By re-syncing DO_NOT_IMPORT_INNER IntelliJ config from ErrorProne BadImport.BAD_NESTED_CLASSES
Before this PR
IntelliJ settings for inner static class names to not import were out of sync with ErrorProne's BadImport check. This causes IntelliJ to produce/allow code that ErrorProne would then fail on.
After this PR
==COMMIT_MSG==
==COMMIT_MSG==
This is an extension of #1617, which initially populated the list.
Possible downsides?