-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring IntelliJ in sync with ErrorProne on bad inner static class names #2447
Conversation
Generate changelog in
|
<DO_NOT_IMPORT_INNER> | ||
<CLASS name="Builder" /> | ||
<CLASS name="BuilderFactory" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this has been out of sync for a while
@@ -54,6 +56,7 @@ | |||
<CLASS name="Type" /> | |||
<CLASS name="Key" /> | |||
<CLASS name="Id" /> | |||
<CLASS name="Identifier" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was recently added to error-prone
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.184.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Bring IntelliJ in sync with ErrorProne on bad inner static class names | palantir/gradle-baseline#2447 | | Fix | Suppress the `JavaxInjectOnAbstractMethod` check for projects that apply `java-gradle-plugin`. | palantir/gradle-baseline#2460 | To enable or disable this check, please contact the maintainers of Excavator.
By re-syncing DO_NOT_IMPORT_INNER IntelliJ config from ErrorProne BadImport.BAD_NESTED_CLASSES
Before this PR
IntelliJ settings for inner static class names to not import were out of sync with ErrorProne's BadImport check. This causes IntelliJ to produce/allow code that ErrorProne would then fail on.
After this PR
==COMMIT_MSG==
==COMMIT_MSG==
This is an extension of #1617, which initially populated the list.
Possible downsides?