-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ImmutableMapDuplicateKeyStrategy for obvious map construction #2416
Conversation
Generate changelog in
|
...r-prone/src/main/java/com/palantir/baseline/errorprone/ImmutableMapDuplicateKeyStrategy.java
Outdated
Show resolved
Hide resolved
…prone/ImmutableMapDuplicateKeyStrategy.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this. I'm curious to see the generated excavators as this rolls out.
Released 4.179.0 |
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.179.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Implement ImmutableMapDuplicateKeyStrategy for obvious map construction. By default we suggest replacing `build()` with the more descriptive `buildOrThrow()`, however `buildKeepingLast()` may be the original intent in some cases. | palantir/gradle-baseline#2416 | To enable or disable this check, please contact the maintainers of Excavator.
==COMMIT_MSG==
Implement ImmutableMapDuplicateKeyStrategy for obvious map construction. By default we suggest replacing
build()
with the more descriptivebuildOrThrow()
, howeverbuildKeepingLast()
may be the original intent in some cases.==COMMIT_MSG==
Possible downsides?
Code churn