java versions preview enhancements #2376

j-baker · 2022-09-09T12:48:07Z

support setting preview on a project-by-project basis.
Fixes Confusing attempted safety check with XX_PREVIEW #2340
fails more elegantly if javaVersions is set on not-the-root.

+ support setting preview on a project-by-project basis. + Fixes #2340 + fails more elegantly if javaVersions is set on not-the-root.

changelog-app · 2022-09-09T12:48:10Z

Generate changelog in `changelog/@unreleased`

Type

Description

java versions preview enhancements

support setting preview on a project-by-project basis.
Fixes Confusing attempted safety check with XX_PREVIEW #2340
fails more elegantly if javaVersions is set on not-the-root.

Check the box to generate changelog(s)

Generate changelog entry

j-baker · 2022-09-09T12:57:36Z

...rc/main/groovy/com/palantir/baseline/plugins/javaversions/BaselineJavaVersionsExtension.java

@@ -61,6 +70,16 @@ public final void setLibraryTarget(int value) {
        libraryTarget.set(JavaLanguageVersion.of(value));
    }

+    public final void setLibraryTarget(String value) {


this is the bit that solves #2340.

j-baker · 2022-09-09T13:02:25Z

...aseline-java/src/test/groovy/com/palantir/baseline/BaselineJavaVersionIntegrationTest.groovy

@@ -220,7 +250,7 @@ class BaselineJavaVersionIntegrationTest extends IntegrationSpec {
        when:
        buildFile << '''
        javaVersions {
-            libraryTarget = 11
+            libraryTarget = '11'


this just tests that the string format for setting versions works.

j-baker · 2022-09-09T13:30:22Z

...rc/main/groovy/com/palantir/baseline/plugins/javaversions/BaselineJavaVersionsExtension.java

+    private static void throwIfNotRootProject(Project project) {
+        if (!project.equals(project.getRootProject())) {
+            throw new GradleException("The javaVersions extension can only be applied to the root project."
+                    + " Did you mean javaVersion, which can be used to override on a project-by-project basis?");


with this I think we'd have probably saved some time!

j-baker · 2022-09-12T13:11:04Z

...oovy/com/palantir/baseline/plugins/javaversions/SubprojectBaselineJavaVersionsExtension.java

+        throw throwCannotSetFromSubproject();
+    }
+
+    private RuntimeException throwCannotSetFromSubproject() {


FAILURE: Build failed with an exception. * Where: Build file '/Volumes/git/thermite/thermite-simulation/build.gradle' line: 2 * What went wrong: A problem occurred evaluating project ':thermite-simulation'. > The javaVersions extension can only be used from the root project. Did you mean javaVersion, which can be used to override on a project-by-project basis? You used it from thermite-simulation

svc-autorelease · 2022-09-12T13:19:51Z

Released 4.162.0

schlosna · 2022-09-12T14:15:16Z

This change is causing gradle failures on excavator roll out, e.g. palantir/tritium#1566 with error https://app.circleci.com/pipelines/github/palantir/tritium/2471/workflows/d414b195-beff-486c-9316-e13a206f6981/jobs/18979/parallel-runs/0/steps/0-105

FAILURE: Build completed with 2 failures.

1: Task failed with an exception.
-----------
* Where:
Build file '/Volumes/git/palantir/tritium/build.gradle' line: 29

* What went wrong:
A problem occurred evaluating root project 'tritium'.
> failed to access class com.palantir.baseline.plugins.javaversions.BaselineJavaVersionsExtension$LazyJdks from class com.palantir.gradle.jdks.JdksPlugin (com.palantir.baseline.plugins.javaversions.BaselineJavaVersionsExtension$LazyJdks and com.palantir.gradle.jdks.JdksPlugin are in unnamed module of loader org.gradle.internal.classloader.VisitableURLClassLoader @57e989a9)

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
==============================================================================

2: Task failed with an exception.
-----------
* Where:
Build file '/Volumes/git/palantir/tritium/tritium-jmh/build.gradle' line: 17

* What went wrong:
A problem occurred evaluating project ':tritium-jmh'.
> Could not find method api() for arguments [io.dropwizard.metrics:metrics-core] on object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
==============================================================================

* Get more help at https://help.gradle.org

BUILD FAILED in 489ms
On branch roomba/latest-baseline-oss
Your branch is up to date with 'origin/roomba/latest-baseline-oss'.

This reverts commit a163bfa.

schlosna · 2022-09-12T15:02:13Z

See #2379 for fix

###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.162.0 | Type | Description | Link | | ---- | ----------- | ---- | | Feature | java versions preview enhancements<br><br>+ support setting preview on a project-by-project basis.<br>+ Fixes #2340<br>+ fails more elegantly if javaVersions is set on not-the-root. | palantir/gradle-baseline#2376 | ## 4.163.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Fix interface visibility bug | palantir/gradle-baseline#2379 | To enable or disable this check, please contact the maintainers of Excavator.

java versions preview enhancements

48d2b0d

+ support setting preview on a project-by-project basis. + Fixes #2340 + fails more elegantly if javaVersions is set on not-the-root.

svc-changelog and others added 3 commits September 9, 2022 12:48

Add generated changelog entries

5392bbd

tests

1e31675

unused imports

ee0077b

j-baker commented Sep 9, 2022

View reviewed changes

j-baker added 6 commits September 12, 2022 13:33

Fixes after talking to Callum

7e00d28

Fix

d532a67

fix

c58c1c3

fix

ffa4817

Updates after talking to callum

12f572b

efix

8e94f6d

j-baker commented Sep 12, 2022

View reviewed changes

CRogers approved these changes Sep 12, 2022

View reviewed changes

j-baker added the autorelease label Sep 12, 2022

j-baker merged commit a163bfa into develop Sep 12, 2022

j-baker deleted the jbaker/java_versions_ergonomics branch September 12, 2022 13:19

carterkozak added a commit that referenced this pull request Sep 12, 2022

Revert "java versions preview enhancements (#2376)"

177bf80

This reverts commit a163bfa.

carterkozak mentioned this pull request Sep 12, 2022

Revert "java versions preview enhancements (#2376)" #2378

Closed

schlosna mentioned this pull request Sep 12, 2022

Fix bug #2379

Merged

svc-excavator-bot mentioned this pull request Sep 15, 2022

Excavator: Upgrades Baseline to the latest version palantir/conjure-java-example#548

Closed

svc-excavator-bot mentioned this pull request Sep 30, 2022

Excavator: Upgrades Baseline to the latest version palantir/hadoop-crypto#593

Merged

svc-excavator-bot mentioned this pull request Oct 24, 2022

Excavator: Upgrades Baseline to the latest version palantir/docker-proxy-rule#496

Merged

svc-excavator-bot mentioned this pull request Nov 25, 2022

Excavator: Upgrades Baseline to the latest version palantir/gradle-launch-config-plugin#72

Open

svc-excavator-bot mentioned this pull request Mar 23, 2023

Excavator: Upgrades Baseline to the latest version palantir/docker-compose-rule#685

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

java versions preview enhancements #2376

java versions preview enhancements #2376

j-baker commented Sep 9, 2022

changelog-app bot commented Sep 9, 2022 •

edited by j-baker

Loading

j-baker Sep 9, 2022

j-baker Sep 9, 2022

j-baker Sep 9, 2022

j-baker Sep 12, 2022

svc-autorelease commented Sep 12, 2022

schlosna commented Sep 12, 2022

schlosna commented Sep 12, 2022

java versions preview enhancements #2376

java versions preview enhancements #2376

Conversation

j-baker commented Sep 9, 2022

changelog-app bot commented Sep 9, 2022 • edited by j-baker Loading

Generate changelog in changelog/@unreleased

j-baker Sep 9, 2022

Choose a reason for hiding this comment

j-baker Sep 9, 2022

Choose a reason for hiding this comment

j-baker Sep 9, 2022

Choose a reason for hiding this comment

j-baker Sep 12, 2022

Choose a reason for hiding this comment

svc-autorelease commented Sep 12, 2022

schlosna commented Sep 12, 2022

schlosna commented Sep 12, 2022

changelog-app bot commented Sep 9, 2022 •

edited by j-baker

Loading

Generate changelog in `changelog/@unreleased`