fix #2328 Handle safety flow through instanceof pattern matching #2331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
commented
Jul 25, 2022
fawind
reviewed
Jul 26, 2022
| @@ -34,4 +34,5 @@ moduleJvmArgs { | |||
| 'jdk.compiler/com.sun.tools.javac.tree', | |||
| 'jdk.compiler/com.sun.tools.javac.util' | |||
| ] | |||
| opens = ['jdk.compiler/com.sun.tools.javac.comp'] | |||
There was a problem hiding this comment.
For my understanding, why do we need the additional "opens" declaration now? I don't see any new usage in the diff here.
There was a problem hiding this comment.
This allows this module to pass tests using jdk17. Not required for the build, but initially I tried using jdk17 everywhere, but some tests are more difficult to fix.
|
Released 4.148.0 |
This was referenced Jul 26, 2022
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Jul 26, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.148.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Handle safety flow through instanceof pattern matching | palantir/gradle-baseline#2331 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==COMMIT_MSG==
Handle safety flow through instanceof pattern matching
==COMMIT_MSG==