Update AvoidNewHashMapInt to include HashSet #2292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
pkoenig10
force-pushed
the
pkoenig/hashSet
branch
from
54e1aeb to
0da04a4
Compare
schlosna
reviewed
Jun 6, 2022
There was a problem hiding this comment.
Overall LGTM, one spelling nit
Just an FYI there's some pending release Guava & JDK changes for capacity calculation google/guava#5965 & openjdk/jdk@3e39304 , google/guava@6ad621e
There's also JDK HashMap.newHashMap(int) & HashSet.newHashSet(int) equivalents to the Guava Maps.newHashMapWithExpectedSize(int) and Sets.newHashSetWithExpectedSize(int) likely landing in JDK 19 openjdk/jdk#7928 & openjdk/jdk#8302 respectively
baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/AvoidNewHashMapInt.java
Outdated
Show resolved
Hide resolved
…prone/AvoidNewHashMapInt.java Co-authored-by: David Schlosnagle <davids@palantir.com>
carterkozak
approved these changes
Jun 6, 2022
|
I've disqualified myself, @schlosna mind giving this a 👍 as well? |
schlosna
approved these changes
Jun 6, 2022
|
Released 4.140.0 |
This was referenced Jun 6, 2022
Merged
This was referenced Jun 6, 2022
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Jun 6, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.140.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Update `AvoidNewHashMapInt` to warn on uses of `new HashSet(int)`. | palantir/gradle-baseline#2292 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #1773, but for
HashSet.