Revert adding eclipse annotation processing/goomph to baseline #2279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Already supplied by gradle-processors.
Generate changelog in
|
carterkozak
approved these changes
May 16, 2022
bulldozer-bot
bot
deleted the
callumr/revert-processor-changes-to-reduce-conflicts
branch
|
Released 4.138.0 |
This was referenced May 16, 2022
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
May 16, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.137.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Immutables redactions may be unsafe (previously forced do-not-log) | palantir/gradle-baseline#2277 | ## 4.138.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Removed built in support for eclipse annotation processor configurations - please use [gradle-processors](https://github.com/palantir/gradle-processors) instead if using eclipse. | palantir/gradle-baseline#2279 | ## 4.139.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Rerelease due to failed publish | palantir/gradle-baseline#2280 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced May 16, 2022
This was referenced May 16, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
In #2076, some code was added to make annotation processing work in eclipse using
aptvia a plugin calledgoomph. This has some downsides:After this PR
==COMMIT_MSG==
Removed built in support for eclipse annotation processor configurations - please use gradle-processors instead if using eclipse.
==COMMIT_MSG==
Possible downsides?