Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert adding eclipse annotation processing/goomph to baseline #2279

Merged

Conversation

CRogers
Copy link
Contributor

@CRogers CRogers commented May 16, 2022

Before this PR

In #2076, some code was added to make annotation processing work in eclipse using apt via a plugin called goomph. This has some downsides:

  1. We already have a plugin to configure annotation processing to work in eclipse (as well as idea): gradle-processors. This should be all that's required to get the annotation processing working - if it isn't, that should be the place to fix it.
  2. The goomph library made the classpath have conflicts, which is transitivity spreading the conflicts to all projects that use baseline as a library
  3. We need to try to keep our dependency surface area as small as possible for SSCS reasons - we should bias towards our own plugin rather than adding new dependencies, especially for gradle plugins.

After this PR

==COMMIT_MSG==
Removed built in support for eclipse annotation processor configurations - please use gradle-processors instead if using eclipse.
==COMMIT_MSG==

Possible downsides?

@CRogers CRogers requested a review from carterkozak May 16, 2022 16:38
@changelog-app
Copy link

changelog-app bot commented May 16, 2022

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Removed built in support for eclipse annotation processor configurations - please use gradle-processors instead if using eclipse.

Check the box to generate changelog(s)

  • Generate changelog entry

@bulldozer-bot bulldozer-bot bot merged commit 8ec32c1 into develop May 16, 2022
@bulldozer-bot bulldozer-bot bot deleted the callumr/revert-processor-changes-to-reduce-conflicts branch May 16, 2022 16:46
@svc-autorelease
Copy link
Collaborator

Released 4.138.0

bulldozer-bot bot pushed a commit to palantir/witchcraft-api that referenced this pull request May 16, 2022
###### _excavator_ is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

# Release Notes
## 4.137.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Improvement | Immutables redactions may be unsafe (previously forced do-not-log) | palantir/gradle-baseline#2277 |


## 4.138.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Fix | Removed built in support for eclipse annotation processor configurations - please use [gradle-processors](https://github.com/palantir/gradle-processors) instead if using eclipse. | palantir/gradle-baseline#2279 |


## 4.139.0
| Type | Description | Link |
| ---- | ----------- | ---- |
| Fix | Rerelease due to failed publish | palantir/gradle-baseline#2280 |



To enable or disable this check, please contact the maintainers of Excavator.
This was referenced May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants