Fix concurrency issue in LazilyConfiguredMapping #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
commented
May 12, 2022
| private final List<LazyValues<K, V, A>> values = new ArrayList<>(); | ||
|
|
||
| @GuardedBy("this") | ||
| private final Map<K, Optional<V>> computedValues = new HashMap<>(); |
There was a problem hiding this comment.
Considered swapping to a ConcurrentHashmap which handles nested mutations more gracefully, however that's not expected to happen (and isn't related to this issue).
pkoenig10
approved these changes
May 12, 2022
|
Released 4.134.0 |
This was referenced May 12, 2022
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
May 12, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.132.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Safety analysis checks superinterfaces (in addition to superclasses) | palantir/gradle-baseline#2267 | ## 4.133.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | More lazily acquire JDK storage locations | palantir/gradle-baseline#2263 | ## 4.134.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Fix concurrency issue in LazilyConfiguredMapping | palantir/gradle-baseline#2268 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==COMMIT_MSG==
Fix concurrency issue in LazilyConfiguredMapping
==COMMIT_MSG==