More laziness to prevent Stackoverflow exceptions.

[CRogers]

Before this PR

When testing this out on a real project using a jdk provider that did a configuration resolutions, Gradle checks (for some reason) checks whether JavaCompile are using toolchains:

https://github.com/gradle/gradle/blob/v7.4.2/subprojects/plugins/src/main/java/org/gradle/api/plugins/JavaBasePlugin.java#L290

This then causes a loop:

* What went wrong:
Could not determine the dependencies of task ':compileJava'.
> Failed to query the value of extension 'errorprone' property 'enabled'.
   > Failed to calculate the value of extension 'javaVersions' property 'jdks'.
      > Could not resolve all dependencies for configuration ':dockerBaseImages'.
         > Failed to calculate the value of task ':compileJava' property 'javaCompiler'.
            > Failed to calculate the value of extension 'javaVersions' property 'jdks'.
               > Could not resolve all dependencies for configuration ':dockerBaseImages'.
                  > Failed to calculate the value of task ':compileJava' property 'javaCompiler'.
                     > Failed to calculate the value of extension 'javaVersions' property 'jdks'.
                        > Could not resolve all dependencies for configuration ':dockerBaseImages'.
                           > Failed to calculate the value of task ':compileJava' property 'javaCompiler'.

        // continues forever
        at com.palantir.gradle.jdks.JdksPlugin.lambda$apply$1(JdksPlugin.java:55)
        // snip
        at org.gradle.api.plugins.JavaBasePlugin.lambda$determineCompatibility$7(JavaBasePlugin.java:290)
        at org.gradle.util.internal.GUtil.uncheckedCall(GUtil.java:458)
        at org.gradle.internal.extensibility.ConventionAwareHelper$2.doGetValue(ConventionAwareHelper.java:96)
        at org.gradle.internal.extensibility.ConventionAwareHelper$MappedPropertyImpl.getValue(ConventionAwareHelper.java:147)
        at org.gradle.internal.extensibility.ConventionAwareHelper.getConventionValue(ConventionAwareHelper.java:129)
        at org.gradle.api.tasks.compile.JavaCompile_Decorated.getTargetCompatibility(Unknown Source)
        at org.gradle.api.plugins.jvm.internal.DefaultJvmPluginServices.lambda$configureDefaultTargetPlatform$5(DefaultJvmPluginServices.java:228)
        at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration.preventFromFurtherMutation(DefaultConfiguration.java:1092)
        // snip        com.palantir.dockerbaseimages.gradle.resolver.BaseImageResolver.resolveDockerBaseImagesDistThrowing(BaseImageResolver.java:99)
        at com.palantir.gradle.javadist.RootSlsDockerPlugin.lambda$apply$4(RootSlsDockerPlugin.java:35)
        // snip
        at com.palantir.gradle.jdks.DelayedConfigurableMap.lambda$get$3(DelayedConfigurableMap.java:69)
        at com.palantir.gradle.jdks.DelayedConfigurableMap.get(DelayedConfigurableMap.java:68)
        // snip
        at com.palantir.gradle.jdks.JdksPlugin.lambda$apply$1(JdksPlugin.java:55)
        // snip
        at org.gradle.api.plugins.JavaBasePlugin.lambda$determineCompatibility$7(JavaBasePlugin.java:290)

After this PR

==COMMIT_MSG==
Make interactions with gradle java toolchains more lazy, so StackOverflowErrors do not occur
==COMMIT_MSG==

Possible downsides?

[changelog-app]

Generate changelog in changelog/@unreleased

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

Make interactions with gradle java toolchains more lazy, so StackOverflowErrors do not occur

Check the box to generate changelog(s)

• Generate changelog entry

[carterkozak]

Hmm

Caused by: java.lang.ClassCastException: class com.palantir.baseline.plugins.javaversions.BaselineJavadocTool cannot be cast to class org.gradle.api.tasks.javadoc.internal.JavadocToolAdapter

[CRogers]

@carterkozak Very, very unfortunately Gradle casts the public interface for JavadocTool to the internal JavadocToolAdapter:

https://github.com/gradle/gradle/blob/v7.4.2/subprojects/language-java/src/main/java/org/gradle/api/tasks/javadoc/Javadoc.java#L207

So I've had to extend that class (thankfully none of it is final) and managed to inject what it needs to work. It feels brittle doing this but we don't have a choice. The only possibly redeeming factor is this seems to not have changed in 2 years since it was created.

[carterkozak]

Least gross option, heh

[svc-autorelease]

Released 4.130.0