Require safety propagation based on getters #2218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
commented
Apr 22, 2022
Comment on lines
+42
to
+43
| // This will be promoted after an initial rollout period | ||
| severity = BugPattern.SeverityLevel.SUGGESTION, |
There was a problem hiding this comment.
This is currently SUGGESTION so I can excavate fixes in a way that's decoupled from baseline upgrades.
|
Released 4.112.0 |
This was referenced Apr 25, 2022
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Apr 25, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.112.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | `SafeLoggingPropagation` error-prone check propages log-safety annotations from getters and superclasses/superinterfaces to the type level | palantir/gradle-baseline#2218 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==COMMIT_MSG==
Require log-safety annotation propagation based detected getters and superclasses/superinterfaces
==COMMIT_MSG==
We combine the safety of superclasses, as well as getters (non-static methods with zero parameters and non-void return type) to estimate the safety of a class. We only apply unsafe/do-not-log annotations as this heuristic is not exhaustive, so we bias toward cases in which we're confident we can be safer.