-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade errorprone to 2.12.1 (from 2.11.0) #2181
Conversation
Generate changelog in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -173,7 +173,9 @@ private static void configureErrorProneOptions( | |||
"CatchSpecificity", | |||
"InlineMeSuggester", | |||
"PreferImmutableStreamExCollections", | |||
"UnusedVariable"); | |||
"UnusedVariable", | |||
// We don't use 'var' yet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// We don't use 'var' yet | |
// We don't use 'var' yet, see VarUsage |
"UnusedVariable"); | ||
"UnusedVariable", | ||
// We don't use 'var' yet | ||
"Varifier"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more explicitly, https://github.com/palantir/gradle-baseline/blob/develop/baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/VarUsage.java throws error: [VarUsage] The
var keyword results in illegible code in most cases and should not be used.
so conflicts with Varifier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 good call, I've described the rationale in the comment
Released 4.98.0 |
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.97.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Fix errorprone excluded-path regex on Windows | palantir/gradle-baseline#2178 | ## 4.98.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Upgrade errorprone to 2.12.1 (from 2.11.0) | palantir/gradle-baseline#2181, https://github.com/google/error-prone/releases/tag/v2.12.0, https://github.com/google/error-prone/releases/tag/v2.12.1 | To enable or disable this check, please contact the maintainers of Excavator.
==COMMIT_MSG==
Upgrade errorprone to 2.12.1 (from 2.11.0)
==COMMIT_MSG==
Release notes:
https://github.com/google/error-prone/releases/tag/v2.12.0
https://github.com/google/error-prone/releases/tag/v2.12.1
New checks