Upgrade errorprone to 2.12.1 (from 2.11.0) #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
robert3005
approved these changes
Apr 6, 2022
schlosna
reviewed
Apr 6, 2022
| @@ -173,7 +173,9 @@ private static void configureErrorProneOptions( | |||
| "CatchSpecificity", | |||
| "InlineMeSuggester", | |||
| "PreferImmutableStreamExCollections", | |||
| "UnusedVariable"); | |||
| "UnusedVariable", | |||
| // We don't use 'var' yet | |||
There was a problem hiding this comment.
Suggested change
| // We don't use 'var' yet | |
| // We don't use 'var' yet, see VarUsage |
| "UnusedVariable"); | ||
| "UnusedVariable", | ||
| // We don't use 'var' yet | ||
| "Varifier"); |
There was a problem hiding this comment.
more explicitly, https://github.com/palantir/gradle-baseline/blob/develop/baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/VarUsage.java throws error: [VarUsage] The var keyword results in illegible code in most cases and should not be used. so conflicts with Varifier
There was a problem hiding this comment.
👍 good call, I've described the rationale in the comment
|
Released 4.98.0 |
This was referenced Apr 6, 2022
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Apr 6, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.97.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | Fix errorprone excluded-path regex on Windows | palantir/gradle-baseline#2178 | ## 4.98.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Upgrade errorprone to 2.12.1 (from 2.11.0) | palantir/gradle-baseline#2181, https://github.com/google/error-prone/releases/tag/v2.12.0, https://github.com/google/error-prone/releases/tag/v2.12.1 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==COMMIT_MSG==
Upgrade errorprone to 2.12.1 (from 2.11.0)
==COMMIT_MSG==
Release notes:
https://github.com/google/error-prone/releases/tag/v2.12.0
https://github.com/google/error-prone/releases/tag/v2.12.1
New checks