Support safety passthrough on several streamlike methods #2174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
fawind
reviewed
Apr 4, 2022
| "min", | ||
| "max", | ||
| "findFirst", | ||
| "findAny")); |
There was a problem hiding this comment.
Shouldn't this be every instance method on Stream that returns another Stream or even 'Collection'? Maybe we can list those methods using reflection instead of listing them manually?
There was a problem hiding this comment.
Not quite, the list does not include map/flatMap/mapTo* because those methods may modify the safety of a stream. e.g. streamOfUnsafeObject.map(unsafeObject -> unsafeObject.getSafeField()) is safe. Lambda handling for this sort of thing is super duper tough though, and I'm still trying to figure out the best way to do it.
|
Released 4.96.0 |
This was referenced Apr 4, 2022
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Apr 4, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.96.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Support safety passthrough on several streamlike methods | palantir/gradle-baseline#2174 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==COMMIT_MSG==
Support safety passthrough on several streamlike methods
==COMMIT_MSG==