Throwable.getMessage is unsafe by default #2151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
schlosna
reviewed
Mar 30, 2022
| @@ -137,6 +137,11 @@ | |||
| private static final Matcher<ExpressionTree> TO_STRING = | |||
| MethodMatchers.instanceMethod().anyClass().named("toString").withNoParameters(); | |||
|
|
|||
| private static final Matcher<ExpressionTree> THROWABLE_GET_MESSAGE = MethodMatchers.instanceMethod() | |||
| .onDescendantOf(Throwable.class.getName()) | |||
| .named("getMessage") | |||
There was a problem hiding this comment.
we should also treat Throwable#getLocalizedMessage() as unsafe as well
There was a problem hiding this comment.
Great idea, updated! Let me know if you think of other types/methods which are always unsafe.
Throwable.toString() is unsafe as well, but I'd like to handle that differently later on in a way that captures string covnersion e.g. "exception: " + myException;
fawind
approved these changes
Mar 31, 2022
|
Released 4.85.0 |
This was referenced Mar 31, 2022
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Mar 31, 2022
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.85.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Throwable.getMessage is unsafe by default | palantir/gradle-baseline#2151 | ## 4.86.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Ban java deserialization | palantir/gradle-baseline#2152 | ## 4.87.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Array assignment merges safety rather than replacing it | palantir/gradle-baseline#2154 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==COMMIT_MSG==
Throwable.getMessage is unsafe by default
==COMMIT_MSG==